Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement multi step registration experiment #1215

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: implement multi step registration experiment #1215

merged 2 commits into from
Apr 18, 2024

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Apr 8, 2024 •
edited
Loading

Description

This PR implements a Multi Step Registration A/B experiment

Control Variant: Registration form with 2 steps. (Name, email and password on first step. Username and country of second step).
Multi-step registration variant: Registration form with 3 steps. (Email field on first page. Name and password on second page. Username and country on 3rd and last page).

JIRA

VAN-1902

How Has This Been Tested?

Locally

Screenshots/sandbox (optional):

Variation:

Screen.Recording.2024-04-16.at.4.56.39.PM.mov

Control:

Screen.Recording.2024-04-16.at.4.54.14.PM.mov

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner April 8, 2024 10:08
@syedsajjadkazmii syedsajjadkazmii marked this pull request as draft April 8, 2024 10:08
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch 7 times, most recently from f436dcf to 27dffdb Compare April 9, 2024 08:45
@syedsajjadkazmii syedsajjadkazmii marked this pull request as ready for review April 9, 2024 08:45
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch 2 times, most recently from 1df0d00 to 75596a3 Compare April 15, 2024 06:35
mubbsharanwar
mubbsharanwar reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we activate the experiment or get the variation on the backend to enable the autogenerated username flag in case of variation?
If we use the full stack optimizely experiment the user would not be authenticated when lands on the registration page where we are activating the experiment. How can we use optimizely full stack, I mean I think optimizely full stack requires only authenticated users to activate the experiment.
Please correct me if my understanding is wrong about the full stack optimizely.

@syedsajjadkazmii
Copy link
Contributor Author

How would we activate the experiment or get the variation on the backend to enable the autogenerated username flag in case of variation?
If we use the full stack optimizely experiment the user would not be authenticated when lands on the registration page where we are activating the experiment. How can we use optimizely full stack, I mean I think optimizely full stack requires only authenticated users to activate the experiment.
Please correct me if my understanding is wrong about the full stack optimizely.

We are not hiding username, we are just moving it 3rd step. So no need to autogenerate username

@mubbsharanwar
Copy link
Contributor

How would we activate the experiment or get the variation on the backend to enable the autogenerated username flag in case of variation?
If we use the full stack optimizely experiment the user would not be authenticated when lands on the registration page where we are activating the experiment. How can we use optimizely full stack, I mean I think optimizely full stack requires only authenticated users to activate the experiment.
Please correct me if my understanding is wrong about the full stack optimizely.

We are not hiding username, we are just moving it 3rd step. So no need to autogenerate username

Oh, I missed it. got it, thank you!

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch from 75596a3 to 0f778cb Compare April 16, 2024 11:34
mubbsharanwar
mubbsharanwar approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch from 0f778cb to b9f0dd2 Compare April 18, 2024 05:28
@syedsajjadkazmii
feat: add multi step registration eventing (#1226)
a270423 
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
@syedsajjadkazmii syedsajjadkazmii merged commit 90f650c into 2u-main Apr 18, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1902-multi-step-registration branch April 18, 2024 06:09
@ahtesham-quraish ahtesham-quraish restored the sajjad/VAN-1902-multi-step-registration branch May 9, 2024 07:16
@ahtesham-quraish ahtesham-quraish deleted the sajjad/VAN-1902-multi-step-registration branch May 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubbsharanwar mubbsharanwar mubbsharanwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syedsajjadkazmii @mubbsharanwar